Skip to content

Tidy up msw handlers used for scenario replay#1649

Merged
charisk merged 1 commit intomainfrom
charisk/handler-tidy-up
Oct 25, 2022
Merged

Tidy up msw handlers used for scenario replay#1649
charisk merged 1 commit intomainfrom
charisk/handler-tidy-up

Conversation

@charisk
Copy link
Copy Markdown
Contributor

@charisk charisk commented Oct 24, 2022

Updated the handlers created for replaying scenarios in the mock GitHub API server so that a single handler is used for each type of request. This is not required but I thought it would make things a bit more consistent.

Checklist

N/A - internal only:

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@charisk charisk requested a review from koesie10 October 24, 2022 15:31
@charisk charisk requested a review from a team as a code owner October 24, 2022 15:31
koesie10
koesie10 approved these changes Oct 25, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@koesie10 koesie10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tidying this up!

@charisk charisk merged commit 130d8ef into main Oct 25, 2022
@charisk charisk deleted the charisk/handler-tidy-up branch October 25, 2022 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@koesie10 koesie10 koesie10 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@charisk @koesie10